Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate packet endpoints #111

Merged

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Jun 28, 2022

/_packet/version and /_packet/health are deprecated in favor of
/versionz and /heathz respectively. This is in an effort to remove vendor specific endpoints that don't need to be vendor specific.

The deprecated APIs will continue working until the 0.8 release.

Fixes #96

/_packet/version and /_packet/health are deprecated in favor of
/versionz and /heathz respectively.

Signed-off-by: Chris Doherty <[email protected]>
@chrisdoherty4 chrisdoherty4 force-pushed the feature/deprecate-packet-endpoints branch from 6e4b9ae to d6eb9dd Compare June 28, 2022 00:18
@codecov
Copy link

codecov bot commented Jun 28, 2022

Codecov Report

Merging #111 (d6eb9dd) into main (592588c) will increase coverage by 3.33%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #111      +/-   ##
==========================================
+ Coverage   39.96%   43.29%   +3.33%     
==========================================
  Files           8        8              
  Lines         578      582       +4     
==========================================
+ Hits          231      252      +21     
+ Misses        314      299      -15     
+ Partials       33       31       -2     
Impacted Files Coverage Δ
http/server.go 90.00% <100.00%> (+1.11%) ⬆️
grpc/server.go 54.43% <0.00%> (+10.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 592588c...d6eb9dd. Read the comment docs.

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Jun 28, 2022
@mergify mergify bot merged commit 34573a1 into tinkerbell:main Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate public facing APIs/endpoints that aren't Hegel specific
2 participants