Implemented new API for Hegel #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisdoherty4
previously approved these changes
Jul 29, 2022
chrisdoherty4
previously approved these changes
Aug 1, 2022
srikarsganti
force-pushed
the
main
branch
3 times, most recently
from
37f86a8 to
aad5549
Compare
Signed-off-by: Srikar Ganti <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #118 +/- ##
===========================================
- Coverage 43.29% 25.60% -17.70%
===========================================
Files 8 9 +1
Lines 582 914 +332
===========================================
- Hits 252 234 -18
- Misses 299 644 +345
- Partials 31 36 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. |
chrisdoherty4
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a new Hegel metadata API that can be queried. Added CLI flag "hegel-api" which defaults to false, but if its enabled, the new API will be served.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: