Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added vendor data endpoint. Changed formatting #121

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

srikarsganti
Copy link
Contributor

Signed-off-by: Srikar Ganti [email protected]

Description

Added vendor data endpoint to API. Added newlines after all HTTP GET requests.

Why is this needed

Adding to the v0 Hegel changes.

Fixes: #

How Has This Been Tested?

Not well tested. TODO.

How are existing users impacted? What migration steps/scripts do we need?

Feature + Formatting fixes.

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@jacobweinstock jacobweinstock self-requested a review August 16, 2022 20:21
@codecov
Copy link

codecov bot commented Aug 16, 2022

Codecov Report

Merging #121 (0ea86d7) into main (3a29154) will decrease coverage by 0.33%.
The diff coverage is 6.66%.

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   25.60%   25.26%   -0.34%     
==========================================
  Files           9        9              
  Lines         914      930      +16     
==========================================
+ Hits          234      235       +1     
- Misses        644      659      +15     
  Partials       36       36              
Impacted Files Coverage Δ
http/api.go 0.00% <0.00%> (ø)
hardware/kubernetes.go 39.51% <100.00%> (+0.49%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4
Copy link
Member

chrisdoherty4 commented Aug 19, 2022

We'll write tests separately for this in conjunction with the other endpoints.

@chrisdoherty4 chrisdoherty4 merged commit 76ce4df into tinkerbell:main Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants