Handle gRPC shutdown from context cancel #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where a single ctrl-c to hegel doesn't shutdown gRPC server and requires another ctrl-c in order for hegel to exit at all. This causes deployments into envs like Kubernetes to have to be force-ably killed in order to shutdown. Signed-off-by: Jacob Weinstock <[email protected]>
This allows the make target for building the image to use whatever the host system has set for GOPROXY. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 25.26% 25.16% -0.11%
==========================================
Files 9 9
Lines 930 934 +4
==========================================
Hits 235 235
- Misses 659 663 +4
Partials 36 36
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chrisdoherty4
approved these changes
Sep 2, 2022
|
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at beca565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes an issue where a single ctrl-c to hegel doesn't shutdown the gRPC server and requires another ctrl-c in order for hegel to exit at all. This causes deployments into envs like Kubernetes to have to be force-ably killed in order to shutdown.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: