Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gRPC API #123

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Sep 15, 2022

The gRPC API is no longer required and is being removed without deprecation. This change simplifies Hegel as we progress toward exposing Hegel's own metadata endpoints.

The gRPC API is no longer required and is being removed without
deprecation.

Signed-off-by: Chris Doherty <[email protected]>
@chrisdoherty4 chrisdoherty4 force-pushed the feature/remove-grpc-api branch from 9a21e43 to 2379f52 Compare September 15, 2022 01:02
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #123 (2379f52) into main (beca565) will decrease coverage by 5.20%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   26.98%   21.77%   -5.21%     
==========================================
  Files           9        8       -1     
  Lines         934      744     -190     
==========================================
- Hits          252      162      -90     
+ Misses        648      560      -88     
+ Partials       34       22      -12     
Impacted Files Coverage Δ
http/handlers.go 55.10% <ø> (+7.42%) ⬆️
http/server.go 76.19% <ø> (-1.59%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Sep 15, 2022

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at bd6979c

@mergify mergify bot merged commit bd6979c into tinkerbell:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants