Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated CLI args #124

Merged

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Sep 15, 2022

Remove deprecated CLI flags.

Closes #92

@chrisdoherty4 chrisdoherty4 force-pushed the feature/remove-deprecated-options branch from 3378588 to 787de17 Compare September 15, 2022 01:11
@chrisdoherty4 chrisdoherty4 changed the title Remove gRPC API Remove deprecated CLI args Sep 15, 2022
@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #124 (3eee76e) into main (b59af19) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   21.77%   21.77%           
=======================================
  Files           8        8           
  Lines         744      744           
=======================================
  Hits          162      162           
  Misses        560      560           
  Partials       22       22           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4 chrisdoherty4 force-pushed the feature/remove-deprecated-options branch from 787de17 to bf2fc3e Compare September 15, 2022 11:46
@chrisdoherty4 chrisdoherty4 marked this pull request as ready for review September 15, 2022 11:46
Signed-off-by: Chris Doherty <[email protected]>
@chrisdoherty4 chrisdoherty4 force-pushed the feature/remove-deprecated-options branch from bf2fc3e to 3eee76e Compare September 16, 2022 14:57
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Sep 16, 2022
@chrisdoherty4
Copy link
Member Author

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2022

queue

✅ The pull request has been merged automatically

The pull request has been merged automatically at 7328b18

@mergify mergify bot merged commit 7328b18 into tinkerbell:main Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove deprecated CLI and env vars
2 participants