Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cacher backend #127

Merged
merged 1 commit into from
Oct 24, 2022

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Oct 20, 2022

Remove the cacher backend and the deprecated 'Watch' APIs. The cacher backend is obsolete and not used in the context of the Tinkerbell project. There are no known long-term usecases hence this is a good simplification.

Closes #126

@chrisdoherty4 chrisdoherty4 force-pushed the feat/remove-cacher-backend branch 5 times, most recently from e9b5a2a to 740fe46 Compare October 24, 2022 16:39
jacobweinstock
jacobweinstock previously approved these changes Oct 24, 2022
Signed-off-by: Chris Doherty <[email protected]>
@codecov
Copy link

codecov bot commented Oct 24, 2022

Codecov Report

Merging #127 (3ac2c99) into main (7328b18) will increase coverage by 2.49%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   21.77%   24.26%   +2.49%     
==========================================
  Files           8        7       -1     
  Lines         744      680      -64     
==========================================
+ Hits          162      165       +3     
+ Misses        560      493      -67     
  Partials       22       22              
Impacted Files Coverage Δ
hardware/client.go 0.00% <0.00%> (ø)
hardware/kubernetes.go 40.16% <ø> (+0.64%) ⬆️
hardware/tink.go 0.00% <ø> (ø)
http/server.go 77.77% <100.00%> (+1.58%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Oct 24, 2022
@mergify mergify bot merged commit cff71d4 into tinkerbell:main Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove cacher back-end
2 participants