-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compatibility with tink #13
Conversation
data_fetch.go
Outdated
const ( | ||
cacherDataModel = ` | ||
{ | ||
"id": "8978e7d4-1a55-4845-8a66-a5259236b104", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why this id is hard coded here? and the same comments go to other hard coded size and numbers in this structure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a mock of what would be returned from cacher so that in the tests we don't have to actually make calls to cacher. I'm working on moving these constants into the actual test file so it's not confusing like so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if just for testing, fine for now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For coding style related comments, like more informational file header and function header comments, we can do that later. But every time we touch a file or a function is an opportunity to add those.
(Sorry I made a branch directly off of the main repo...)
Changes:
HARDWARE_DATA_MODEL
to switch between the old cacher model and the new tinkerbell modeltinkerbell
, it will default to using the old cacher data modelexportedHardware
among others to take into account new data modelTODO:
replace
ingo.mod
pointing to my fork (after the pr in tink gets merged)Subscribe
method (honestly, not sure how)hegel/main.go
Line 145 in ec7c033
Related PRs:
boots: tinkerbell/smee#27
tink: tinkerbell/tink#64