Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sources to /internal and rename some APIs #134

Merged
merged 2 commits into from
Nov 3, 2022

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Oct 29, 2022

Move sources under /internal so its clear nothing in this repository is intended for import. Additionally tidy the package API for /internal/xff to simplify calls.

@chrisdoherty4 chrisdoherty4 changed the title Remove custom endpoints Move sources to /internal and rename some APIs Oct 29, 2022
@codecov
Copy link

codecov bot commented Oct 29, 2022

Codecov Report

Merging #134 (252ae11) into main (6ea659c) will decrease coverage by 0.07%.
The diff coverage is 37.50%.

@@            Coverage Diff             @@
##             main     #134      +/-   ##
==========================================
- Coverage   24.26%   24.19%   -0.08%     
==========================================
  Files           7        7              
  Lines         680      682       +2     
==========================================
  Hits          165      165              
- Misses        493      494       +1     
- Partials       22       23       +1     
Impacted Files Coverage Δ
internal/hardware/client.go 0.00% <0.00%> (ø)
internal/hardware/export.go 0.00% <ø> (ø)
internal/hardware/tink.go 0.00% <ø> (ø)
internal/http/api.go 0.00% <ø> (ø)
internal/http/handlers.go 55.10% <ø> (ø)
internal/hardware/kubernetes.go 40.16% <33.33%> (ø)
internal/http/server.go 74.46% <50.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4 chrisdoherty4 marked this pull request as ready for review November 3, 2022 00:06
@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Nov 3, 2022
@chrisdoherty4 chrisdoherty4 merged commit ae4d443 into tinkerbell:main Nov 3, 2022
@chrisdoherty4 chrisdoherty4 deleted the feat/move-sources branch November 3, 2022 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants