Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor release workflow #147

Merged

Conversation

chrisdoherty4
Copy link
Member

@chrisdoherty4 chrisdoherty4 commented Nov 4, 2022

The actions/create-release Github action has been archived. This change set moves to a different action that creates releases in a similar way to the current process.

The action used to create releases is https://github.com/ncipollo/release-action.

I tested the release workflow with a tag pushed to the Hegel repository and everything works fine. Successful run can be found under actions.

@chrisdoherty4 chrisdoherty4 force-pushed the feat/refactor-release-workflow branch from f813fe9 to 90db3b5 Compare November 4, 2022 13:07
Signed-off-by: Chris Doherty <[email protected]>
@chrisdoherty4 chrisdoherty4 force-pushed the feat/refactor-release-workflow branch from 90db3b5 to 59935ae Compare November 4, 2022 13:07
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #147 (d81c877) into main (9d420dc) will decrease coverage by 0.48%.
The diff coverage is 42.16%.

@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   20.68%   20.19%   -0.49%     
==========================================
  Files           7       11       +4     
  Lines         672      703      +31     
==========================================
+ Hits          139      142       +3     
- Misses        514      540      +26     
- Partials       19       21       +2     
Impacted Files Coverage Δ
internal/hardware/client.go 0.00% <ø> (ø)
internal/hardware/kubernetes.go 39.51% <0.00%> (-0.65%) ⬇️
internal/hardware/tink.go 0.00% <0.00%> (ø)
internal/http/handler/hegel.go 0.00% <ø> (ø)
internal/http/handler/health_check.go 4.54% <4.54%> (ø)
internal/http/handler/version.go 9.09% <9.09%> (ø)
internal/http/server.go 55.55% <46.15%> (-17.42%) ⬇️
internal/http/handler/handler.go 70.00% <70.00%> (ø)
internal/http/handler/ec2.go 37.71% <100.00%> (ø)
internal/xff/xff.go 92.30% <100.00%> (ø)
... and 3 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chrisdoherty4 chrisdoherty4 force-pushed the feat/refactor-release-workflow branch 8 times, most recently from 7fbd8d3 to dd4c1dd Compare November 4, 2022 14:26
Signed-off-by: Chris Doherty <[email protected]>
@mmlb
Copy link
Contributor

mmlb commented Nov 7, 2022

hook uses https://github.com/softprops/action-gh-release in https://github.com/tinkerbell/hook/blob/main/.github/workflows/ci.yaml#L144. I don't remember why I used softprops instead of ncipollo's but there was likely a reason. Worth a look to see if the project as a whole can use just 1 releaser.

@displague
Copy link
Member

Both projects are suggested as alternatives in https://github.com/actions/create-release#github-action---releases-api

Between softprops and ncipollo, the latter appears to be more active, while the former has more forks and stars. 🤷‍♂️

Using the same project throughout Tinkerbell would be nice, but this PR doesn't change that existing state nor prevent future movement in that direction.

@displague
Copy link
Member

displague commented Nov 7, 2022

I didn't see an image push in the fork's successful build. Let's make sure the next release pushes.

@chrisdoherty4
Copy link
Member Author

chrisdoherty4 commented Nov 7, 2022

I never tried out the softprops one, but I compared what ncipollo produces with what we produce today and they were very similar (we no longer produce "new contributors" with this change).

I'm not particularly bothered which solution we use long term, the primary goal of the PR is to get off an archived and clearly unsupported action.

I didn't see an image push in the fork's successful build. Let's make sure the next release pushes.

It was purposely commented out during those test runs because it relies on a successful build from mainline (as it did previously). Given this hasn't been merged yet, there is no successful build from mainline to release, hence it would fail in the normal way when trying to copy the image.

@chrisdoherty4 chrisdoherty4 merged commit 090ba3f into tinkerbell:main Nov 7, 2022
@chrisdoherty4 chrisdoherty4 deleted the feat/refactor-release-workflow branch November 7, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants