-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor release workflow #147
Refactor release workflow #147
Conversation
f813fe9
to
90db3b5
Compare
Signed-off-by: Chris Doherty <[email protected]>
90db3b5
to
59935ae
Compare
Codecov Report
@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 20.68% 20.19% -0.49%
==========================================
Files 7 11 +4
Lines 672 703 +31
==========================================
+ Hits 139 142 +3
- Misses 514 540 +26
- Partials 19 21 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
7fbd8d3
to
dd4c1dd
Compare
Signed-off-by: Chris Doherty <[email protected]>
dd4c1dd
to
d81c877
Compare
hook uses https://github.com/softprops/action-gh-release in https://github.com/tinkerbell/hook/blob/main/.github/workflows/ci.yaml#L144. I don't remember why I used softprops instead of ncipollo's but there was likely a reason. Worth a look to see if the project as a whole can use just 1 releaser. |
Both projects are suggested as alternatives in https://github.com/actions/create-release#github-action---releases-api Between softprops and ncipollo, the latter appears to be more active, while the former has more forks and stars. 🤷♂️ Using the same project throughout Tinkerbell would be nice, but this PR doesn't change that existing state nor prevent future movement in that direction. |
I didn't see an image push in the fork's successful build. Let's make sure the next release pushes. |
I never tried out the softprops one, but I compared what ncipollo produces with what we produce today and they were very similar (we no longer produce "new contributors" with this change). I'm not particularly bothered which solution we use long term, the primary goal of the PR is to get off an archived and clearly unsupported action.
It was purposely commented out during those test runs because it relies on a successful build from mainline (as it did previously). Given this hasn't been merged yet, there is no successful build from mainline to release, hence it would fail in the normal way when trying to copy the image. |
The
actions/create-release
Github action has been archived. This change set moves to a different action that creates releases in a similar way to the current process.The action used to create releases is https://github.com/ncipollo/release-action.
I tested the release workflow with a tag pushed to the Hegel repository and everything works fine. Successful run can be found under actions.