Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove conditional login on release workflow #150

Merged

Conversation

chrisdoherty4
Copy link
Member

Stop conditionally logging into quay.io on release workflows.

Release workflows are gated on tags so the need to gate the login is superfluous and leads to misleading 400 Bad Request errors from quay.io.

@chrisdoherty4 chrisdoherty4 force-pushed the fix/release-quay-login branch from dfcec60 to 3db0565 Compare November 7, 2022 23:23
@codecov
Copy link

codecov bot commented Nov 7, 2022

Codecov Report

Merging #150 (3db0565) into main (d81c877) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   20.19%   20.19%           
=======================================
  Files          11       11           
  Lines         703      703           
=======================================
  Hits          142      142           
  Misses        540      540           
  Partials       21       21           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Nov 7, 2022
@chrisdoherty4
Copy link
Member Author

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2022

queue

✅ The pull request has been merged manually

The pull request has been merged manually at 964a79c

@chrisdoherty4
Copy link
Member Author

@Mergifyio dequeue

@chrisdoherty4 chrisdoherty4 merged commit 964a79c into tinkerbell:main Nov 7, 2022
@chrisdoherty4 chrisdoherty4 deleted the fix/release-quay-login branch November 7, 2022 23:32
@mergify
Copy link
Contributor

mergify bot commented Nov 7, 2022

Sorry but I didn't understand the command. Please consult the commands documentation 📚.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants