Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to Kubernetes as the backend and modify kubernetes cli args #171

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

chrisdoherty4
Copy link
Member

Default to Kubernetes as the backend for Hegel. Additionally, modify the Kubernetes backend specific CLI flags (and consequently env vars) so they follow the standard for backend identifying configuration.

Closes #168
Closes #169

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #171 (6991ed0) into main (9cf720a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #171   +/-   ##
=======================================
  Coverage   78.65%   78.65%           
=======================================
  Files           9        9           
  Lines         253      253           
=======================================
  Hits          199      199           
  Misses         49       49           
  Partials        5        5           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@displague displague added the ready-to-merge Signal to Mergify to merge the PR. label Nov 15, 2022
@chrisdoherty4 chrisdoherty4 merged commit 0d203db into tinkerbell:main Nov 15, 2022
@chrisdoherty4 chrisdoherty4 deleted the feat/default-backend branch November 15, 2022 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use prefixes for backend CLI flags. Change to Kubernetes as the default backend
2 participants