Fix Docker Action migration from v1 to v2 #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gianarb
force-pushed
the
hotfix/hegel-image-tags
branch
from
77190e0 to
662a8e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 23.95% 23.95%
=======================================
Files 5 5
Lines 501 501
=======================================
Hits 120 120
Misses 359 359
Partials 22 22 Continue to review full report at Codecov.
|
I trusted too much the green check in CI and I didn't notice the warning: ``` Warning: Unexpected input(s) 'registry', 'tag_with_sha', valid inputs are ['builder', 'context', 'file', 'build-args', 'labels', 'tags', 'pull', 'target', 'allow', 'no-cache', 'platforms', 'load', 'push', 'outputs', 'cache-from', 'cache-to', 'secrets', 'github-token'] ``` This should fix the issue as explained here https://github.com/docker/build-push-action/blob/818fbc81014f50430ad3c990e14d744b09e3b80d/UPGRADE.md#tags-with-ref-and-git-labels Signed-off-by: Gianluca Arbezzano <[email protected]>
gianarb
force-pushed
the
hotfix/hegel-image-tags
branch
from
662a8e2 to
c185a3d
Compare
mmlb
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I trusted too much the green check in CI and I didn't notice the
warning:
This should fix the issue as explained here https://github.com/docker/build-push-action/blob/818fbc81014f50430ad3c990e14d744b09e3b80d/UPGRADE.md#tags-with-ref-and-git-labels