Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi arch support for Docker image #47

Merged
merged 1 commit into from
Oct 28, 2020
Merged

Multi arch support for Docker image #47

merged 1 commit into from
Oct 28, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Oct 27, 2020

Fixed #46
Fixed #21

@gianarb gianarb requested a review from a team October 27, 2020 21:23
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   23.95%   23.95%           
=======================================
  Files           5        5           
  Lines         501      501           
=======================================
  Hits          120      120           
  Misses        359      359           
  Partials       22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb1cb7...2cd8b6c. Read the comment docs.

@gianarb gianarb requested review from mmlb and removed request for mmlb October 28, 2020 16:24
mmlb
mmlb previously approved these changes Oct 28, 2020
Signed-off-by: Gianluca Arbezzano <[email protected]>
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Oct 28, 2020
@mmlb mmlb merged commit 916276c into tinkerbell:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Actions produced container images are broken Multiarch build and image support
2 participants