Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove site-eng from CODEOWNERS #50

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

mmlb
Copy link
Contributor

@mmlb mmlb commented Nov 6, 2020

Description

Remove site-eng team as codeowners.

Why is this needed

This was done to ensure site-eng was watching and commenting on PRs to
avoid introducing bc-breaks that would affect EM legacy production. This
is no longer needed, and just tends to block PRs for longer than
necessary.

@mmlb mmlb requested a review from a team November 6, 2020 20:34
@mmlb mmlb changed the title ## Description Remove site-eng from CODEOWNERS Nov 6, 2020
@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #50 (6442d24) into master (916276c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #50   +/-   ##
=======================================
  Coverage   23.95%   23.95%           
=======================================
  Files           5        5           
  Lines         501      501           
=======================================
  Hits          120      120           
  Misses        359      359           
  Partials       22       22           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 916276c...6442d24. Read the comment docs.

This was done to ensure site-eng was watching and commenting on PRs to
avoid introducing bc-breaks that would affect EM legacy production. This
is no longer needed, and just tends to block PRs for longer than
necessary.

Signed-off-by: Manuel Mendez <[email protected]>
detiber
detiber previously approved these changes Nov 6, 2020
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Nov 6, 2020
@mergify mergify bot merged commit 0cec86e into tinkerbell:master Nov 6, 2020
@mmlb mmlb deleted the remove-site-eng-codeowners branch November 6, 2020 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants