switch to not using root user #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since it is not recommended to run docker services as root we're switching to a newly created user `tinkerbell`. Signed-off-by: Mike Mason <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #56 +/- ##
=======================================
Coverage 24.40% 24.40%
=======================================
Files 5 5
Lines 504 504
=======================================
Hits 123 123
Misses 359 359
Partials 22 22 Continue to review full report at Codecov.
|
mmlb
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since it is not recommended to run docker services as root
we're switching to a newly created user
tinkerbell.Why is this needed
Better security standards