add opentelemetry #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 25, 2021 12:48
Signed-off-by: Amy Tobey <[email protected]>
Signed-off-by: Amy Tobey <[email protected]>
Signed-off-by: Amy Tobey <[email protected]>
Signed-off-by: Amy Tobey <[email protected]>
Signed-off-by: Amy Tobey <[email protected]>
tstromberg
approved these changes
Aug 27, 2021
|
Thanks for approving @tstromberg :) I can't merge because I don't have permission on this repo. |
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
+ Coverage 33.49% 33.57% +0.07%
==========================================
Files 3 3
Lines 409 420 +11
==========================================
+ Hits 137 141 +4
- Misses 249 256 +7
Partials 23 23
Continue to review full report at Codecov.
|
mmlb
added a commit
to mmlb/tinkerbell-hegel
that referenced
this pull request
Oct 28, 2021
Hegel learned how to do otel tracing in Amy's otel [PR], but missed out on picking up the distributed/linked tracing that was added to packethost/pkg/grpc. PR: tinkerbell#64 This PR bumps packethost/pkg to pick up its automagic otel grpc middleware setup. Signed-off-by: Manuel Mendez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds OpenTelemetry plumbing and instrumentation for HTTP and gRPC.
How Has This Been Tested?
Existing tests pass.
How are existing users impacted? What migration steps/scripts do we need?
No change until the otel environment variables are set.