Update pkg and otel #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 13, 2021 13:18
OpenTelemetry events don't work great on every platform. When this event was added I didn't quite understand how it would work out. The gRPC autoinstrumentation sends plenty of events so these aren't necessary. Signed-off-by: Amy Tobey <[email protected]>
Current dep is broken on otel injection, which causes panics. Signed-off-by: Amy Tobey <[email protected]>
Brings it up to an otel 1.0 release so it's future-compatible. Signed-off-by: Amy Tobey <[email protected]>
|
Replaces #70 |
added 2 commits
December 13, 2021 13:24
Signed-off-by: Amy Tobey <[email protected]>
Signed-off-by: Amy Tobey <[email protected]>
tstromberg
approved these changes
Dec 13, 2021
This was referenced Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
pkgpackage to the latest sha to fix the panic.Updates
otel-init-goto v0.0.4 to fix the otel compatibility thing.Removes a span event that is redundant with those provided by gRPC autoinstrumentaiton.