-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hegelc cleanup #76
Hegelc cleanup #76
Conversation
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Signed-off-by: Marques Johansson <[email protected]>
Note that log.Panic panics and thus defered functions are run, but log.Fatal I think calls os.Exit and does not run defers. I think that's fine though and better for a cli than dumping a stack trace anyway. |
Signed-off-by: Marques Johansson <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #76 +/- ##
=======================================
Coverage 50.71% 50.71%
=======================================
Files 3 3
Lines 418 418
=======================================
Hits 212 212
Misses 175 175
Partials 31 31 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a fan of basically empty main, but oh well not really a big deal either
Description
/hegelc
to/cmd/hegelc
HEGEL_SERVER
,HEGEL_PORT
)-server
,-port
)metadata
frommetadata.packet.net
Fatal
(exit code 1) rather thanPanic
(exit code 2)grpc.DialContext
instead ofgrpc.Dial
Why is this needed
Fixes: #67
How Has This Been Tested?
ran with
-help
, env variables set, flags set. Attempted invalid ports and hostnames and got appropriate errors.How are existing users impacted? What migration steps/scripts do we need?
The default server changes from metadata.packet.net to metadata.
Checklist:
I have: