Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Intel networking driver to support Intel NUCs #61

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

micahhausler
Copy link
Contributor

Description

Enable support for Intel NUC network driver.

Why is this needed

I am running a small homelab with Intel NUCs, I want networking :). The ARM kernel config already includes this module.

How Has This Been Tested?

I ran the following, and updated hook.yaml with the resulting image

make -C hook/kernel -j 16 kconfig_amd64 KCONFIG_TAG=hack
make -C hook/kernel  -j 16 devbuild_5.10.x

How are existing users impacted? What migration steps/scripts do we need?

Probably need to change the kernel image in hook.yaml to one under the tinkerbell name instead of thebsdbox/kernel:5.10.bpf

Checklist:

I have:

  • updated the documentation and/or roadmap (if required): I'll do this in a follow up PR
  • added unit or e2e tests: N/A
  • provided instructions on how to upgrade: N/A

@micahhausler micahhausler force-pushed the kernel-opts branch 3 times, most recently from 2a84481 to a25f3ee Compare June 22, 2021 18:22
* Added clean target to kernel Makefile
* Fixed kernel CI

Signed-off-by: Micah Hausler <[email protected]>
@micahhausler
Copy link
Contributor Author

@thebsdbox @markyjackson-taulia I updated the kernel CI build to make -C kernel devbuild instead of just the build target, CI was bombing on arm64 emulation errors which I also experienced on my machine. Is that something you're OK with for getting CI to work for amd64 targets at least? I feel like debugging kernel build failures using qemu is out-of-scope for this PR

@markjacksonfishing
Copy link
Contributor

@thebsdbox @markyjackson-taulia I updated the kernel CI build to make -C kernel devbuild instead of just the build target, CI was bombing on arm64 emulation errors which I also experienced on my machine. Is that something you're OK with for getting CI to work for amd64 targets at least? I feel like debugging kernel build failures using qemu is out-of-scope for this PR

@micahhausler this is totally ok by me

Copy link
Contributor

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WOOT!

@markjacksonfishing markjacksonfishing merged commit 086ac16 into tinkerbell:main Jun 22, 2021
@micahhausler micahhausler deleted the kernel-opts branch June 22, 2021 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants