Fix errors from lint-install run. #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raj-Dharwadkar
force-pushed
the
lint-fix
branch
2 times, most recently
from
84ae53f to
d0bf920
Compare
tstromberg
suggested changes
Aug 28, 2021
This comment has been minimized.
This comment has been minimized.
Fix all the errors reported from lint-install cd tink-docker; ../out/linters/golangci-lint-v1.42.0 run cd bootkit; ../out/linters/golangci-lint-v1.42.0 run Fix Makefile error. Test: make image make dev Signed-off-by: Raj-Dharwadkar <[email protected]>
Raj-Dharwadkar
force-pushed
the
lint-fix
branch
from
d0bf920 to
2533946
Compare
tstromberg
approved these changes
Aug 30, 2021
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix all the errors reported from lint-install
cd tink-docker; ../out/linters/golangci-lint-v1.42.0 run
cd bootkit; ../out/linters/golangci-lint-v1.42.0 run
Fix Makefile error.
Description
Why is this needed
Fixes: #
How Has This Been Tested?
Test:
make image
make dev
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: