This repository has been archived by the owner on Dec 31, 2021. It is now read-only.
Add support for the latest tink-worker udpate that changed the env variable used for the worker ID #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…riable used for the worker ID Signed-off-by: Jason DeTiberus <[email protected]>
detiber
force-pushed
the
fixTinkWorkerEnv
branch
from
03bf477 to
57eb147
Compare
mmlb
approved these changes
Oct 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for the latest tink-worker changes to command line arguments/env variables after tinkerbell/tink#287 merged
Why is this needed
Testing using the latest published images is broken, since tink-worker is looking for the ID env variable rather than WORKER_ID, this PR adds forward and backward compatible support.
How Has This Been Tested?
Currently testing now using the tilt configuration I'm working on in https://github.com/detiber/tink/tree/kindDev, but it could also be tested using the vagrant or terraform setups with the changes needed to point to an osie build.
How are existing users impacted? What migration steps/scripts do we need?
No additional migrations or scripts should be needed, it should not impact users.