Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
## Description This PR fixes the binary names to be both correct and also "unsurprising". ## Why is this needed Avoids needing to COPY all the binaries, only to keep 1. Also avoids glaringly misnamed binaries :D. For example these are the binaries built from master: ``` file boots-* | sed 's|, statically.*||' boots-linux-aarch64: ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV) boots-linux-amd64: ELF 64-bit LSB executable, x86-64, version 1 (SYSV) boots-linux-arm64: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV) boots-linux-armv7l: ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV) boots-linux-x86_64: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV) ``` notice the 32bit arm v6 binary is named aarch64 and x86_64 is actually 386! Here is from this PR: ``` [~/go/src/github.com/tinkerbell/boots]─[manny@dellnix]> file boots-* | sed 's|, statically.*||' boots-linux-386: ELF 32-bit LSB executable, Intel 80386, version 1 (SYSV) boots-linux-amd64: ELF 64-bit LSB executable, x86-64, version 1 (SYSV) boots-linux-arm64: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV) boots-linux-armv6: ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV) boots-linux-armv7: ELF 32-bit LSB executable, ARM, EABI5 version 1 (SYSV) ``` ## How Has This Been Tested? Inspecting each file with `file`, docker build works. ## How are existing users impacted? What migration steps/scripts do we need? Any user using the cross compiled binaries directly will be impacted, but this should most likely be 0 users since they will likely use plain-old `boots` binary instead.
- Loading branch information