Allow registry, registry username and password to be empty strings #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These values are passed as kernel command line args for OSIE's boot up and then used by Tink worker when it pulls and runs containers. With a recent change Tink worker, allowing the empty string here provides Tink worker the ability to specify any full qualified container image in a template. This change is backward compatible and shouldn't negatively affect using the Cacher backend. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #254 +/- ##
==========================================
- Coverage 39.57% 39.53% -0.05%
==========================================
Files 39 39
Lines 2772 2775 +3
==========================================
Hits 1097 1097
- Misses 1587 1590 +3
Partials 88 88
Continue to review full report at Codecov.
|
mmlb
reviewed
Apr 18, 2022
sure, i can add that. |
Signed-off-by: Jacob Weinstock <[email protected]>
mmlb
approved these changes
Apr 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow registry, registry username, and password to be empty strings. These values are passed as kernel command line args for OSIE's boot up and then used by Tink worker when it pulls and runs containers. With this change to Tink worker, allowing the empty string here provides Tink worker the ability to specify any fully qualified container image in a template. e.g.
docker.io/alpine,quay.io/tinkerbell-actions/cexec,public.ecr.aws/l0g8r8j6/tinkerbell/pbnj, etcThis change is backward compatible and shouldn't negatively affect using the Cacher backend.
Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: