Import index funcs from Tink #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Micah Hausler <[email protected]>
micahhausler
force-pushed
the
indexers/import
branch
from
1359e71 to
cfea28f
Compare
Codecov Report
@@ Coverage Diff @@
## main #268 +/- ##
===================================
Coverage 35% 36%
===================================
Files 41 41
Lines 2740 2711 -29
===================================
Hits 984 984
+ Misses 1691 1662 -29
Partials 65 65
Continue to review full report at Codecov.
|
jacobweinstock
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Micah Hausler [email protected]
Description
This change imports indexing functions from Tinkerbell and deduplicates logic copied into boots. Follow up from tinkerbell/tink#620