Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove github.com/pkg/errors as a direct dependency: #338

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

jacobweinstock
Copy link
Member

Description

This library has been archived. All the functionality exist in the stdlib now.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This library has been archived. All the functionality
exist in the stdlib now.

Signed-off-by: Jacob Weinstock <[email protected]>
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #338 (4c9f511) into main (53e2f8e) will increase coverage by 0%.
The diff coverage is 0%.

❗ Current head 4c9f511 differs from pull request most recent head b690331. Consider uploading reports for the commit b690331 to get more accurate results

@@         Coverage Diff         @@
##           main   #338   +/-   ##
===================================
  Coverage    30%    30%           
===================================
  Files         6      6           
  Lines       426    424    -2     
===================================
  Hits        129    129           
+ Misses      288    286    -2     
  Partials      9      9           
Files Changed Coverage Δ
cmd/boots/env.go 32% <ø> (ø)
cmd/boots/main.go 0% <0%> (ø)
ipxe/script/ipxe.go 25% <0%> (+<1%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@chrisdoherty4 chrisdoherty4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Aug 18, 2023
@mergify mergify bot merged commit c838d18 into tinkerbell:main Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants