Fix nil pointer error: #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When in proxyDHCP mode if AllowNetboot is false Smee would panic because of this log line. This resolves this issue. Signed-off-by: Jacob Weinstock <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #483 +/- ##
===================================
Coverage 69% 69%
===================================
Files 16 16
Lines 1434 1434
===================================
+ Hits 991 993 +2
+ Misses 415 414 -1
+ Partials 28 27 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When in proxyDHCP mode if AllowNetboot is false Smee would panic because of this log line. This resolves the issue.
Why is this needed
Fixes: #482
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: