Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and Go 1.22 -> 1.23 #548

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

jacobweinstock
Copy link
Member

Description

This includes a fix in the embedded ipxe script from tinkerbell/ipxedust. Also, upgrade to building with Go 1.23.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This includes a fix in the embedded
ipxe script from tinkerbell/ipxedust.

Signed-off-by: Jacob Weinstock <[email protected]>
Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock changed the title Update dependencies: Update dependencies and Go 1.22 -> 1.23 Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51%. Comparing base (abd9a80) to head (f0b1ac3).
Report is 3 commits behind head on main.

Additional details and impacted files
@@         Coverage Diff         @@
##           main   #548   +/-   ##
===================================
  Coverage    50%    51%           
===================================
  Files        26     26           
  Lines      2757   2757           
===================================
+ Hits       1402   1409    +7     
+ Misses     1312   1307    -5     
+ Partials     43     41    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jacobweinstock jacobweinstock merged commit 00ce18f into tinkerbell:main Nov 8, 2024
5 checks passed
@jacobweinstock jacobweinstock deleted the update-ipxedust branch November 8, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant