-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Let's adopt Bors to merge PRs #145
Comments
This looks cool 👍 |
@grahamc Can we also look at Mergify as an alternative to Bors? |
Absolutely. Any chance you could have a merging config file PR for Standup today?
…On Thu, Jun 4, 2020, at 9:08 AM, Gaurav Gahlot wrote:
@grahamc <https://github.com/grahamc> Can we also look at Mergify <https://mergify.io/> as an alternative to Bors?
It uses a configuration file (like this one <https://github.com/infracloudio/botkube/blob/develop/.mergify.yml>) and allows us to have customization that best suits our needs.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#145 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASXLEIK3PB3AIXEPFFV5LRU6MDFANCNFSM4NQ2O5PQ>.
|
Mergify* of course. Autocorrect is a bear.
…On Thu, Jun 4, 2020, at 9:47 AM, Graham Christensen wrote:
Absolutely. Any chance you could have a merging config file PR for Standup today?
On Thu, Jun 4, 2020, at 9:08 AM, Gaurav Gahlot wrote:
>
>
> @grahamc <https://github.com/grahamc> Can we also look at Mergify <https://mergify.io/> as an alternative to Bors?
> It uses a configuration file (like this one <https://github.com/infracloudio/botkube/blob/develop/.mergify.yml>) and allows us to have customization that best suits our needs.
>
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub <#145 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASXLEIK3PB3AIXEPFFV5LRU6MDFANCNFSM4NQ2O5PQ>.
>
|
Done. #148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The "require being up to date with master before merging" restriction is a good idea, but makes it really tricky to merge PRs. We could get this same benefit but with automation and without the race to merge a PR by using bors: https://bors.tech/
All we have to do is click enable here: https://github.com/apps/bors and read https://bors.tech/documentation/getting-started/
I propose adding this to all the tinkerbell repos.
The text was updated successfully, but these errors were encountered: