Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let's adopt Bors to merge PRs #145

Closed
grahamc opened this issue Jun 2, 2020 · 5 comments
Closed

Let's adopt Bors to merge PRs #145

grahamc opened this issue Jun 2, 2020 · 5 comments

Comments

@grahamc
Copy link
Contributor

grahamc commented Jun 2, 2020

The "require being up to date with master before merging" restriction is a good idea, but makes it really tricky to merge PRs. We could get this same benefit but with automation and without the race to merge a PR by using bors: https://bors.tech/

All we have to do is click enable here: https://github.com/apps/bors and read https://bors.tech/documentation/getting-started/

I propose adding this to all the tinkerbell repos.

@dustinmiller
Copy link

This looks cool 👍

@gauravgahlot
Copy link
Contributor

@grahamc Can we also look at Mergify as an alternative to Bors?
It uses a configuration file (like this one) and allows us to have customization that best suits our needs.

@grahamc
Copy link
Contributor Author

grahamc commented Jun 4, 2020 via email

@grahamc
Copy link
Contributor Author

grahamc commented Jun 4, 2020 via email

@gauravgahlot
Copy link
Contributor

Done. #148

@grahamc grahamc closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants