Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete pkg package #300

Closed
mmlb opened this issue Sep 18, 2020 · 5 comments
Closed

Delete pkg package #300

mmlb opened this issue Sep 18, 2020 · 5 comments
Assignees
@vigneshashokan
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S estimate of the amount of work to address the issue

Comments

@mmlb
Copy link
Contributor

mmlb commented Sep 18, 2020

pkg packages is an anti pattern. Instead we should break out its contents into smaller/easier to use packages.
@mmlb mmlb added kind/feature Categorizes issue or PR as related to a new feature. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. size/S estimate of the amount of work to address the issue labels Sep 18, 2020
@mmlb mmlb mentioned this issue Sep 18, 2020
Merged
3 tasks
@detiber
Copy link
Contributor

detiber commented Sep 18, 2020

+1000, we should also move anything that we don't intend to expose as a public API into one or more 'internal' packages

@vigneshashokan
Copy link

@mmlb If no one is working on this, I can take a stab at this issue.

@gauravgahlot
Copy link
Contributor

gauravgahlot commented Sep 23, 2020 •
edited
Loading

@vigneshashokan I don't think anyone is working on it yet. I will assign the issue to you.

Please take a read at the communication doc and do let us know if you face any issues in the slack channel.

Looking forward to your contribution. 😄

@mmlb mmlb mentioned this issue Oct 1, 2020
Merged
3 tasks
@mmlb
Copy link
Contributor Author

mmlb commented Oct 2, 2020

@vigneshashokan I've done one part in #315 already.

mergify bot added a commit that referenced this issue Oct 7, 2020
@mergify
Move workflow stuff out of pkg (#315)
30f4302 
## Description

Move workflow types and funcs out of pkg/ and into its own package. Also cleaned up some of the API and added some more validation while I'm here.

## Why is this needed

Helps address #300 

## How Has This Been Tested?

`go test` passes.


## How are existing users impacted? What migration steps/scripts do we need?

Low impact. A bc-break is occurring here, but its in internalish code and no user is expected to be using this code. If they are `gofmt -w -r 'p.ParseYAML(b) -> p.Parse(b)' .` and removing the call to `ValidateTemplate` is all thats needed.

## Checklist:

I have:

- [ ] updated the documentation and/or roadmap (if required)
- [x] added unit or e2e tests
- [ ] provided instructions on how to upgrade
@tstromberg tstromberg added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Aug 27, 2021
@chrisdoherty4
Copy link
Member

Stale issue. Some of this work is being addressed with an overhaul of the Tink repository anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vigneshashokan vigneshashokan

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. hacktoberfest kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. size/S estimate of the amount of work to address the issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@tstromberg @mmlb @detiber @gianarb @chrisdoherty4 @vigneshashokan @gauravgahlot