Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow version needs bump #440

Closed
mmlb opened this issue Feb 18, 2021 · 3 comments
Closed

Workflow version needs bump #440

mmlb opened this issue Feb 18, 2021 · 3 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@mmlb
Copy link
Contributor

mmlb commented Feb 18, 2021

The workflow/template spec effectively changed via #436 but tink's validation wasn't updated and should be. We should also validate that only "" and "host" are accepted.

Expected Behaviour

Running a workflow template with pid namespace config should fail on older tink deployments. We should support template version 0.2 and only support pid ns in templates >= 0.2.

Current Behaviour

Pid namespace is not applied on older tink.
There's no validation that only "" or "host" are provided.

@mmlb
Copy link
Contributor Author

mmlb commented Feb 18, 2021

I've got the beginnings of some code for this already but can't continue with it for a little while yet.

@mmlb
Copy link
Contributor Author

mmlb commented Feb 18, 2021

@thebsdbox bringing to your attention

@tstromberg tstromberg added kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Aug 27, 2021
@chrisdoherty4
Copy link
Member

chrisdoherty4 commented Dec 24, 2022

Workflows and Templates are now modeled using Kubernetes CRDs. CRDs have their own versioning mechanism so we are unlikely to need an additional versioning scheme on top. Consequently, we're trending towards removal of template versioning making this obsolete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

3 participants