Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pid namespace support #436

Merged
merged 3 commits into from
Feb 11, 2021
Merged

Pid namespace support #436

merged 3 commits into from
Feb 11, 2021

Conversation

thebsdbox
Copy link
Contributor

Description

This PR updates the action protos with a pid option of type string, following the --pid flag for the docker engine. The most common use-case is to pass the string host to the pid option which will allow the action to run in the same process ID namespace as the host itself.

Why is this needed

This adds the capability to both cleanly kexec and reboot as an action.

Fixes: 👉 (an already merged kexec action on the tinkerbell action hub)

How Has This Been Tested?

This has been tested by running a workflow with the kexec action

How are existing users impacted? What migration steps/scripts do we need?

If this isn't used then it defaults to pid: container (or the runtime default)

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #436 (5a8ea61) into master (5752ec8) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #436      +/-   ##
==========================================
+ Coverage   34.71%   34.73%   +0.02%     
==========================================
  Files          47       47              
  Lines        2892     2893       +1     
==========================================
+ Hits         1004     1005       +1     
  Misses       1796     1796              
  Partials       92       92              
Impacted Files Coverage Δ
db/workflow.go 29.20% <100.00%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5752ec8...2fcd03c. Read the comment docs.

Copy link
Contributor

@markjacksonfishing markjacksonfishing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Also tested this yesterday

@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Feb 11, 2021
@mergify mergify bot merged commit a7e947e into tinkerbell:master Feb 11, 2021
@mmlb mmlb mentioned this pull request Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants