not all container images are being tagged in quay.io #641
Assignees
Labels
Comments
mergify bot
added a commit
that referenced
this issue
Oct 4, 2022
## Description Tags were not being pushed to quay.io for services other than quay.io/tinkerbell/tink, this tags tink-controller, tink-worker, and tink-cli with tags as well. ## Why is this needed Fixes: #641 ## How Has This Been Tested? ## How are existing users impacted? What migration steps/scripts do we need? ## Checklist: I have: - [ ] updated the documentation and/or roadmap (if required) - [ ] added unit or e2e tests - [ ] provided instructions on how to upgrade
Repository owner
moved this from In Progress
to Done
in Sandbox v0.7.0 release
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This repo creates multiple container images: tink server, tink controller, tink cli, tink worker. Currently, in code, we tag all of these different binaries together. It appears that only the tink server container image has the associated tag of v0.7.0 in quay.io.
Expected Behaviour
I would like for all container images pushed to quay.io to be tagged.
Current Behaviour
Possible Solution
It appears that our GitHub action for tags current just supports a single image. https://github.com/tinkerbell/tink/blob/main/.github/workflows/tags.yaml We'll probably want to modify this to accommodate all the container images we create.
Steps to Reproduce (for bugs)
Context
Your Environment
Operating System and version (e.g. Linux, Windows, MacOS):
How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:
Link to your project or a code example to reproduce issue:
The text was updated successfully, but these errors were encountered: