Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Workflow's not moving out of STATE_PREPARING: #1055

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

jacobweinstock
Copy link
Member

Description

This resolves an issue where a Workflow with only BootOption -> toggleAllowNetboot: true will stay indefinitely in a preparing state.

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

Sorry, something went wrong.

This resolves an issue where a Workflow with only
BootOption -> toggleAllowNetboot: true will stay
indefinitely in a preparing state.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock jacobweinstock added kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. ready-to-merge Signal to Mergify to merge the PR. kind/regression Categorizes issue or PR as related to a regression from a prior release. labels Jan 9, 2025
@jacobweinstock jacobweinstock merged commit acc982d into tinkerbell:main Jan 9, 2025
10 checks passed
@jacobweinstock jacobweinstock deleted the workflow-bug branch January 9, 2025 16:22
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.42%. Comparing base (66c3d7c) to head (2fe31e9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
+ Coverage   31.39%   31.42%   +0.02%     
==========================================
  Files          75       75              
  Lines        4686     4688       +2     
==========================================
+ Hits         1471     1473       +2     
  Misses       3120     3120              
  Partials       95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. kind/regression Categorizes issue or PR as related to a regression from a prior release. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant