Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #120 (point 3) in setup.sh #123

Merged
merged 1 commit into from
May 20, 2020
Merged

Fix for #120 (point 3) in setup.sh #123

merged 1 commit into from
May 20, 2020

Conversation

parauliya
Copy link
Contributor

Following are the changes:

  1. Removed the rougue "\n"
  2. Replace the link of hello-world example from github docs to the tinkerbell.org website

Fix for tinkerbell#120 in setup.sh
c1fa98c 
Following are the changes:
1. Removed the rougue "\n"
2. Replace the link of hello-world example from github docs to the tinkerbell.org website
@parauliya parauliya requested a review from gauravgahlot May 20, 2020 09:50
@gauravgahlot gauravgahlot merged commit 527cd42 into tinkerbell:master May 20, 2020
@gauravgahlot gauravgahlot deleted the fix_issue_120 branch May 20, 2020 10:19
@gauravgahlot gauravgahlot changed the title Fix for #120 in setup.sh Fix for #120 (point 3) in setup.sh May 20, 2020
@gauravgahlot gauravgahlot added the area/setup Issue related to tinkerbell setup label May 20, 2020
@gauravgahlot gauravgahlot mentioned this pull request May 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravgahlot gauravgahlot gauravgahlot approved these changes

Assignees
No one assigned
Labels
area/setup Issue related to tinkerbell setup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parauliya @gauravgahlot