-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform tweaks #124
Merged
Merged
Terraform tweaks #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
requested review from
gauravgahlot,
parauliya and
nathangoulding
and removed request for
gauravgahlot and
parauliya
May 21, 2020 21:05
parauliya
previously approved these changes
May 26, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please rebase your branch before merging it. |
Helps with #105 |
Don't really like have invalid values in the .tf files, especially when Hashicorp has extensive documentation for setting variables.
To avoid incompatible version bumps.
There is no reason to shadow project_id with a local variable.
s/tf-/tink-/ because this makes more sense especially if using a project that has other servers.
For availability or even latency/locality.
c3.small.x86s are in high demand atm and other devices are just as usable.
This is a dns entry packet adds for all provisioned devices and makes it easier to reach the services running on the provisioner.
@parauliya rebased |
parauliya
approved these changes
Jun 1, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.