Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editorconfig: init #143

Merged
merged 1 commit into from
Jun 4, 2020
Merged

editorconfig: init #143

merged 1 commit into from
Jun 4, 2020

Conversation

grahamc
Copy link
Contributor

@grahamc grahamc commented Jun 1, 2020

I noticed the setup.sh script is a bit confused about indentation. If
everybody sets up an editorconfig plugin for their editor, their
editor will automatically configure itself:
https://editorconfig.org/#download

@mmlb
Copy link
Contributor

mmlb commented Jun 1, 2020

/me needs to dust of shfmt and shellcheck commits I've got laying around somewhere over here.

LGTM after you rebase on top of master.

@grahamc
Copy link
Contributor Author

grahamc commented Jun 1, 2020

Done, @mmlb thanks.

@grahamc
Copy link
Contributor Author

grahamc commented Jun 1, 2020

Ah, I see it merged master in instead of rebasing. Fixed.

mmlb
mmlb previously approved these changes Jun 2, 2020
I noticed the setup.sh script is a bit confused about indentation. If
everybody sets up an editorconfig plugin for their editor, their
editor will automatically configure itself:
https://editorconfig.org/#download
Copy link
Contributor

@gauravgahlot gauravgahlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gauravgahlot gauravgahlot merged commit c84ad0a into tinkerbell:master Jun 4, 2020
@grahamc grahamc deleted the editorconfig branch June 4, 2020 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants