-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker-compose: remove EFK #170
Conversation
a9e0929
to
982ea73
Compare
Unfortunately we have this to reckon with: https://github.com/tinkerbell/osie/blob/master/installer/workflow-helper.sh#L60-L62 |
I got a general 👍 from @mmlb. We should probably adjust the OSIE workflow helper to stop using fluentbit, and just use syslog like ipxe does: https://github.com/tinkerbell/boots/blob/master/ipxe/dhcp_options.go#L68 and like the entrypoint of osie already does:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending ELK -> EFK and missing word in PR message see the logs on the, a
Fetching EFK adds several minutes to the setup time and start-times. I think most hackers will want to just see the logs on the console, and be interested in EFK once things are more prod-like. Using EFK means the user actually has to do some initial config on their cluster, and it doesn't just work out of the box. One problem is OSIE wants to talk specifically to ElasticSearch, but I wonder if we could swap it out with syslog and a syslog listener?
fixup'd, @mmlb ! |
( The description still says EFK instead of ELK ) |
Have you made this an option or removed it completely as I consumed the logs API of elastic search in tinkerbot for the /logs command |
One thing to bear in mind is that log collection is hard when working on PCs in the lab where there is no serial output. The only way I was able to get output was by searching in ElasticSearch when doing this on a regular PC. Is this PR taking that away? |
docker-compose: remove EFK
Fetching EFK adds several minutes to the setup time and start-times.
I think most hackers will want to just see the logs on the console,
and be interested in EFK once things are more prod-like. Using EFK
means the user actually has to do some initial config on their
cluster, and it doesn't just work out of the box.
One problem is OSIE wants to talk specifically to ElasticSearch, but
I wonder if we could swap it out with syslog and a syslog listener?