-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENG-6658 user defined metadata #197
Merged
kqdeng
merged 22 commits into
tinkerbell:master
from
kqdeng:ENG-6658-user-defined-metadata
Jul 24, 2020
Merged
ENG-6658 user defined metadata #197
kqdeng
merged 22 commits into
tinkerbell:master
from
kqdeng:ENG-6658-user-defined-metadata
Jul 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathangoulding
changed the title
Eng 6658 user defined metadata
ENG-6658 user defined metadata
Jul 9, 2020
…h protobuf conventions
kqdeng
force-pushed
the
ENG-6658-user-defined-metadata
branch
from
July 13, 2020 01:20
f730101
to
76acd64
Compare
…show defaults; cleanup
…o server (and also actually write/return the errors)
… template list and workflow list now use jsonpb to display formatted time
kqdeng
force-pushed
the
ENG-6658-user-defined-metadata
branch
from
July 13, 2020 01:24
76acd64
to
17caa6a
Compare
This was referenced Jul 13, 2020
kqdeng
commented
Jul 13, 2020
// writeResponse appends a new line after res | ||
func writeResponse(w http.ResponseWriter, status int, res string) { | ||
w.WriteHeader(status) | ||
if _, err := w.Write([]byte(fmt.Sprintln(res))); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I add a new line at the end of a response or just leave res
as is? (res
is the response string to be printed/written as a response)
nathangoulding
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related PRs:
boots: tinkerbell/smee#58
hegel: tinkerbell/hegel#16
Why is this needed
Fixes: #199
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Users shouldn't notice a difference in pushing/getting hardware data as compared to before, except that now, any and all fields they've pushed under metadata will actually be stored. No migration needed.
For the push data for the hardware push rest endpoint, there is now no need to wrap the hardware data within
{"data": {}}
. For usage examples, refer to this gist.Checklist:
I have: