Move to GitHub action from Drone #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
suggested changes
Aug 5, 2020
.github/workflows/ci.yaml
Outdated
Comment on lines
28
to
29
| - run: make | ||
| name: Build binaries |
There was a problem hiding this comment.
- name: Build binaries
run: maketo match the order of all the other actions
| repository: tinkerbell/tink-server | ||
| path: ./cmd/tink-server/ | ||
| push: ${{ startsWith(github.ref, 'refs/heads/master') }} | ||
| tags: latest |
There was a problem hiding this comment.
Please add
tag_with_ref: true
tag_with_sha: truetoo
There was a problem hiding this comment.
Those options will push:
Successfully tagged quay.io/tinkerbell/tink:latest
Successfully tagged quay.io/tinkerbell/tink:pr-235-merge
Successfully tagged quay.io/tinkerbell/tink:sha-f009303
I don't think we want that
There was a problem hiding this comment.
I do. Maybe not tag_wit_ref for pushes, but definitely for tags. But I do want the sha so we can have point-in-time refs to images, and not just latest that keeps getting pushed up.
There was a problem hiding this comment.
Ok I will leave this tag_with_sha: true.
About tags, that's a separate discussion btw. It is not covered here and I will add it as soon as we get closer to a release lifecycle plan.
it does not look we are close to it
When a new PR gets open: 1. fmt 2. vet 3. test 4. golint-ci 5. ci-check with nixos 6. build docker images 7. push docker images to quay only for master Signed-off-by: Gianluca Arbezzano <[email protected]>
mmlb
approved these changes
Aug 6, 2020
gianarb
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move from Drone to Github Action
Why is this needed
Fixes: #233
How Has This Been Tested?
I am using
actto run GitHub Action locally.How are existing users impacted? What migration steps/scripts do we need?
none
When merged to master: