Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix download artifact during docker build job #245

Merged
merged 1 commit into from
Aug 7, 2020
Merged

fix download artifact during docker build job #245

merged 1 commit into from
Aug 7, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Aug 7, 2020

😫 I think I got it running finally.

@gianarb gianarb requested a review from thebsdbox August 7, 2020 14:24
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Aug 7, 2020
thebsdbox
thebsdbox approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, this path change will fix the wrong paths in the Dockerfiles.

/lgtm

@gianarb gianarb merged commit f5831e4 into tinkerbell:master Aug 7, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebsdbox thebsdbox thebsdbox approved these changes

Assignees
No one assigned
Labels
area/ci-cd-release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gianarb @thebsdbox @mmlb