Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log message contains JSON #260

Merged
merged 1 commit into from
Aug 19, 2020
Merged

Fix log message contains JSON #260

merged 1 commit into from
Aug 19, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Aug 19, 2020

Fixed #259

@gianarb gianarb added size/XS estimate of the amount of work to address the issue priority/backlog Higher priority than priority/awaiting-more-evidence. ready-to-merge Signal to Mergify to merge the PR. labels Aug 19, 2020
@gianarb gianarb requested a review from gauravgahlot August 19, 2020 11:28
Fix log message contains JSON
8bd533f 
Fixed #259

Signed-off-by: Gianluca Arbezzano <[email protected]>
@gauravgahlot
Copy link
Contributor

@gianarb My only questions will be, does this also fix other places in the same code file?

@gianarb
Copy link
Contributor Author

gianarb commented Aug 19, 2020 •
edited
Loading

@gianarb My only questions will be, does this also fix other places in the same code file?

it just fixes the log message reported by @jeremytanner

@gauravgahlot do you mind to approve this and can you have a look at the other possible one to fix? 😇

@mergify mergify bot merged commit cadd62e into tinkerbell:master Aug 19, 2020
kqdeng pushed a commit to kqdeng/tink that referenced this pull request Aug 31, 2020
@Cbkhare
tinkerbell#260 modified tink client name and desc
9973940
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravgahlot gauravgahlot gauravgahlot approved these changes

@thebsdbox thebsdbox thebsdbox approved these changes

Assignees
No one assigned
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence. size/XS estimate of the amount of work to address the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tink-server log outputting broken JSON for tink workflow create
4 participants
@gianarb @gauravgahlot @thebsdbox @mmlb