-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for vagrant/libvirt #264
Conversation
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
==========================================
- Coverage 12.98% 12.36% -0.63%
==========================================
Files 7 7
Lines 1186 1165 -21
==========================================
- Hits 154 144 -10
+ Misses 1021 1010 -11
Partials 11 11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I verified this by running through the https://tinkerbell.org/docs/setup/local-with-vagrant/ docs on Ubuntu 20.04.
To fulfill the prerequisites, I ran:
sudo apt-get install qemu-system-x86 libvirt-daemon-driver-qemu
It was helpful to use virt-manager
to view the Worker. (I attempted to use virsh console vagrant_worker
but never caught meaningful output).
The build failure seems to have hit the 5m timeout, it does appear that vagrant was otherwise successful in provisioning Virtualbox nodes. Breaking virtualbox based vagrant provisioning is the only risk that I could imagine this PR doing, and that does not appear to be the case.
- Adds network name for libvirt private network - Adds a host_ip for libvirt private network, to allow creation of the network if it doesn't already exist+ Signed-off-by: Jason DeTiberus <[email protected]>
Description
Fixes some issues with running the vagrant setup using libvirt:
Why is this needed
Without these changes, vagrant-libvirt fails to provision the hosts or the private network.
How Has This Been Tested?
Successfully ran through the local setup with vagrant instructions here: https://tinkerbell.org/docs/setup/local-with-vagrant/
Host OS: Fedora 32
Vagrant version: 2.2.9 (installed from RPM)
vagrant-libvirt version: 0.1.2 (installed using
vagrant plugin install
)How are existing users impacted? What migration steps/scripts do we need?
I don't expect any impact to existing users, unless those users were also running into issues standing up the vagrant stack with libvirt
Checklist:
I have: