Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump timeout from 5min to 10min #265

Merged
merged 1 commit into from
Aug 21, 2020
Merged

bump timeout from 5min to 10min #265

merged 1 commit into from
Aug 21, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Aug 21, 2020

There is a timeout for the Vagrant Setup guide test at 5minutes. If the
expected set of statuses does not show up in 5 minutes the tests gets
marked as failed.

It works locally but in CI it fails, so this is an attempt to see if it
is only a resource issue

@gianarb gianarb added the ci-check/vagrant-setup This label trigger a GitHub action that tests the Vagrant Setup guide https://tinkerbell.org/setup/ label Aug 21, 2020
@codecov
Copy link

codecov bot commented Aug 21, 2020

Codecov Report

Merging #265 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #265   +/-   ##
=======================================
  Coverage   12.98%   12.98%           
=======================================
  Files           7        7           
  Lines        1186     1186           
=======================================
  Hits          154      154           
  Misses       1021     1021           
  Partials       11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7eb10ca...34841c8. Read the comment docs.

There is a timeout for the Vagrant Setup guide test at 5minutes. If the
expected set of statuses does not show up in 5 minutes the tests gets
marked as failed.

It works locally but in CI it fails, so this is an attempt to see if it
is only a resource issue

Signed-off-by: Gianluca Arbezzano <[email protected]>
@gianarb gianarb added ci-check/vagrant-setup This label trigger a GitHub action that tests the Vagrant Setup guide https://tinkerbell.org/setup/ and removed ci-check/vagrant-setup This label trigger a GitHub action that tests the Vagrant Setup guide https://tinkerbell.org/setup/ labels Aug 21, 2020
@gianarb gianarb requested a review from gauravgahlot August 21, 2020 12:34
@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Aug 21, 2020
}
t.Fatal("Workflow never got to a complite state or it didn't make it on time (5m)")
t.Fatal("Workflow never got to a complite state or it didn't make it on time (10m)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

complite -> complete

Other than that, looks ok

@mergify mergify bot merged commit 0bed1c6 into tinkerbell:master Aug 21, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-check/vagrant-setup This label trigger a GitHub action that tests the Vagrant Setup guide https://tinkerbell.org/setup/
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants