Fixed the duplicate name issue while creating a template

[parauliya]

Name of the template which is used to provide with -n flag while creating a template should be unique.
But there was an issue because of which it was accepting duplicate name as well.
This PR fixed the above issue.

Signed-off-by: parauliya [email protected]

Description

Name of the template which is used to provide with -n flag while creating a template should be unique.
But there was an issue because of which it was accepting duplicate name as well.
This PR fixed the above issue.

Why is this needed

Same as Description.

How Has This Been Tested?

I tried to create multiple template with same name but now they are not being created because of the same name.

How are existing users impacted? What migration steps/scripts do we need?

User need to provide the unique name for each template it is creating in the database.

Checklist:

I have:

• updated the documentation and/or roadmap (if required)
• added unit or e2e tests
• provided instructions on how to upgrade

[codecov]

Codecov Report

Merging #270 into master will increase coverage by 1.74%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   15.34%   17.08%   +1.74%     
==========================================
  Files           9        9              
  Lines        1264     1264              
==========================================
+ Hits          194      216      +22     
+ Misses       1059     1036      -23     
- Partials       11       12       +1     

Impacted Files	Coverage Δ
grpc-server/template.go	19.64% <100.00%> (+19.64%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e14ed36...d06e1b6. Read the comment docs.

[gianarb]

Pretty good! Can you add a Table Test that accepts templates as input and validate the answers, please?

Let's make this coverage green bit by bit!

[gianarb]

Can you call it TestCreateTemplate? and the table test has to work like this imho:
Table Test is not only for one specific use case, but it has to be flexible enough to allow all the one you can think about for the function you are testing, in our case CreateTemplate

// you don't need a testCases struct just use a []testCase
struct testCase type {
    db mock.DB
    name string
    input []string // or templates
    expect func() (*template.CreateResponse, error)
}

In order to figure out if the TableTest is well written can you add three other testcases please?

1. Well formatted and successful template creation (only one)
2. A random validation error if we have any
3. Create 2 templates with a different name, both should work

Thanks

[parauliya]

sure, I will try to add couple of more test cases as you suggested.

[parauliya]

@gianarb As mentioned by you I have modified the test struct ( not exactly as you suggested ) so that in future more tests can be added. And I have also added couple of more test cases. But I was not able to test for validation of template because we don't check the validation of a template in CreateTemplate function. Template is being validated while creating a workflow here https://github.com/tinkerbell/tink/blob/master/db/workflow.go#L98.

[gianarb]

Great! Thanks +1.74% ✅