Fix Terraform setup #276

gianarb · 2020-09-02T09:06:45Z

This is part of the work I am doing with the Terraform Setup guide:

This is part of the work I am doing with the Terraform Setup guide: tinkerbell/tinkerbell.org#129 Signed-off-by: Gianluca Arbezzano <[email protected]>

codecov · 2020-09-02T09:08:15Z

Codecov Report

Merging #276 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   20.61%   20.61%           
=======================================
  Files          15       15           
  Lines        1363     1363           
=======================================
  Hits          281      281           
  Misses       1068     1068           
  Partials       14       14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c57d19b...da4ea2d. Read the comment docs.

displague

Thanks for getting this working simpler, @gianarb

I have a few more changes that will benefit this setup and I'd rather see us get them in one shot. If we change resource names in a later commit people that started with this terraform example will have to transfer state to the renamed resources, for example.

I have my changes staged here: https://github.com/gianarb/tink/compare/fix/update-terraform-setup...displague:terraform-cleanup?expand=1

I'll push these changes into this branch once I have verified them.

gianarb · 2020-09-02T13:55:19Z

Great thanks @displague !

Signed-off-by: Marques Johansson <[email protected]>

…isioning Signed-off-by: Marques Johansson <[email protected]>

displague · 2020-09-02T15:27:44Z

deploy/terraform/main.tf

-      type        = "ssh"
-      user        = var.ssh_user
-      host        = packet_device.tink-provisioner.network[0].address
-      private_key = file(var.ssh_private_key)


@gianarb I removed the private_key because Terraform will use your ssh-agent by default.

The problem with defaulting to "~/.ssh/id_rsa" is that this file is usually encrypted, and Terraform can not use that.

My suggestion is that we ask the user to add the key they want to use to their SSH agent before running terraform apply. For most users, this should already be the case - nothing to do.

An alternative is to ask users to ssh-keygen create a new key in this directory, and tell Terraform to use that.

If we can make private_key optional (use the agent if ssh_private_key is empty) that would be even better. I can look into this.

I added the ssh-agent note as part of the documentation. We can do the fallback work as follow up work 👍

displague · 2020-09-02T15:30:25Z

deploy/terraform/main.tf

  hostname         = "tink-provisioner"
  plan             = var.device_type
  facilities       = [var.facility]
  operating_system = "ubuntu_18_04"
  billing_cycle    = "hourly"
  project_id       = var.project_id
  user_data        = file("install_package.sh")
+}
+
+resource "null_resource" "tink_directory" {


@gianarb by moving the provisioning to a null_resource, provisioning failures (like a missing ssh key) will not require the tink_provisioner host to be recreated. Changes to the tink/ directory can be reapplied (rsync'd) independently. terraform taint null_resource.tink_directory; terraform apply

displague · 2020-09-02T15:32:43Z

deploy/terraform/main.tf

  type      = "layer2-individual"
 }

 # Attach VLAN to provisioner
 resource "packet_port_vlan_attachment" "provisioner" {
-  device_id = packet_device.tink-provisioner.id
+  device_id = packet_device.tink_provisioner.id


I ran into Error: POST https://api.packet.net/ports/bff62cf9-5f23-49fd-b500-686e3d8730b6/assign: 422 still bonded once while testing this. A follow-up terraform apply was successful.

It may make sense to add depends_on = packet_device_network_type.tink_provisioner_network_type here 🤔

It sounds like a reasonable dependency to me, so let's be clear about that and write it down 👍

displague · 2020-09-02T15:34:29Z

deploy/terraform/variables.tf

@@ -8,6 +8,11 @@ variable "project_id" {
  type        = string
 }

+variable "worker_count" {


I haven't checked tinkerbell/tinkerbell.org#129 to see if multiple workers will require any additional doc changes.

No, they will just work! Nice!

rugwirobaker · 2020-09-02T19:38:34Z

I'm quite new to terraform, and for it to work for me I have had to terraform 0.13upgrade . And I'm currently testing with this PR.
I'm using the latest terraform version.

➜  ~ terraform version
Your version of Terraform is out of date! The latest version
is 0.13.2. You can update by downloading from https://www.terraform.io/downloads.html
Terraform v0.13.0

Also something that would make the process faster for the newbies is to include the file my_var.tfvars file mentioned in the docs(I did have to learn terraform so, I guess that's a positive 😆). I'm thinking of something like this:

deploy/
├── example.tfvars 
├── install_package.sh
├── my_var.tfvars // user created copy should be added to .gitignore 
├── main.tf
├── outputs.tf
└── variables.tf

Example: https://github.com/alexellis/sshdkit where the ssh.yml was ignored but we have an example for it in ssh.example.yml
Small thing but it would make the project a little bit more accessible for people like me.

rugwirobaker · 2020-09-02T21:14:44Z

A small hicup running ./setup.sh
Got this error on my first run of terraform apply so I redid it and it went away

Error: POST https://api.packet.net/ports/d6ddf121-3f74-4b43-9a6c-a25edfc40fa5/assign: 422 still bonded 

  on main.tf line 76, in resource "packet_port_vlan_attachment" "provisioner":
  76: resource "packet_port_vlan_attachment" "provisioner" {

Error: POST https://api.packet.net/ports/e16fe28f-e194-409f-9d06-c7c72d07f7b4/assign: 422 still bonded 

  on main.tf line 83, in resource "packet_port_vlan_attachment" "worker":
  83: resource "packet_port_vlan_attachment" "worker" {

But ounce insider the provisioner the setup.sh script failed:

INFO: verifying prerequisites for ubuntu (18.04)                                                                                   [51/719]
       Found prerequisite: docker                                                                                                          
       Found prerequisite: docker-compose                                                                                                  
       Found prerequisite: ip                                                                                                              
       Found prerequisite: jq                                                                                                              
       Found prerequisite: netplan                                                                                                         
INFO: waiting for the network configuration to be applied by systemd-networkd                                                              
.........

Step 7/7 : EXPOSE 443
 ---> Running in b68d63577cca
Removing intermediate container b68d63577cca
 ---> 9d1bdfff2b16
Successfully built 9d1bdfff2b16
Successfully tagged deploy_registry:latest
Recreating deploy_registry_1 ... 
Recreating deploy_registry_1 ... done
Error response from daemon: Get https://192.168.1.1/v2/: net/http: request canceled while waiting for connection (Client.Timeout exceeded w
hile awaiting headers)

I went on but docker-compose up -d could not bring up the nginx container with the following error:

ERROR: for deploy_nginx_1  Cannot start service nginx: driver failed programming external connectivity on endpoint deploy_nginx_1 (7ccfa729
954ae70036255926ac45970b2ddfc6797f7d3b2bf6924ea10b3c4f22): Error starting userland proxy: listen tcp 192.168.1.2:80: bind: cannot assign

…chment Signed-off-by: Marques Johansson <[email protected]>

Signed-off-by: Marques Johansson <[email protected]>

…user@host in output Signed-off-by: Marques Johansson <[email protected]>

Signed-off-by: Marques Johansson <[email protected]>

gianarb requested review from DailyAlice and displague September 2, 2020 09:06

Fix Terraform setup

c7f3853

This is part of the work I am doing with the Terraform Setup guide: tinkerbell/tinkerbell.org#129 Signed-off-by: Gianluca Arbezzano <[email protected]>

gianarb mentioned this pull request Sep 2, 2020

Migrate Terraform setup from tink PR tinkerbell/playground#1

Closed

displague requested changes Sep 2, 2020

View reviewed changes

displague added 2 commits September 2, 2020 11:21

update terraform to 0.13 with 3.0.1 Packet provider

5629713

Signed-off-by: Marques Johansson <[email protected]>

terraform: add multiple workers, safer resource names, retryable prov…

9ea6a7b

…isioning Signed-off-by: Marques Johansson <[email protected]>

displague reviewed Sep 2, 2020

View reviewed changes

displague added 4 commits September 3, 2020 22:55

terraform: add a dependency on worker network_type for port_vlan_atta…

c0d8d5b

…chment Signed-off-by: Marques Johansson <[email protected]>

terraform: chmod scripts before during provision

1970128

Signed-off-by: Marques Johansson <[email protected]>

terraform: terraform 0.13upgrade

69bb79b

Signed-off-by: Marques Johansson <[email protected]>

terraform: generate hardware-data-0.json on provisioner, include sos …

41d92cd

…user@host in output Signed-off-by: Marques Johansson <[email protected]>

displague mentioned this pull request Sep 4, 2020

fix terraform setup guide tinkerbell/tinkerbell.org#129

Merged

terraform: fix file provisioning for worker and provisioner

5d9099c

Signed-off-by: Marques Johansson <[email protected]>

displague approved these changes Sep 5, 2020

View reviewed changes

gianarb removed the request for review from DailyAlice September 7, 2020 06:53

gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Sep 7, 2020

Merge branch 'master' into fix/update-terraform-setup

da4ea2d

mergify bot merged commit 1aef424 into tinkerbell:master Sep 7, 2020

mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Terraform setup #276

Fix Terraform setup #276

gianarb commented Sep 2, 2020

codecov bot commented Sep 2, 2020 •

edited

Loading

displague left a comment

gianarb commented Sep 2, 2020

displague Sep 2, 2020 •

edited

Loading

gianarb Sep 4, 2020

displague Sep 2, 2020

displague Sep 2, 2020 •

edited

Loading

gianarb Sep 2, 2020

displague Sep 2, 2020

gianarb Sep 2, 2020

rugwirobaker commented Sep 2, 2020

rugwirobaker commented Sep 2, 2020

Fix Terraform setup #276

Fix Terraform setup #276

Conversation

gianarb commented Sep 2, 2020

codecov bot commented Sep 2, 2020 • edited Loading

Codecov Report

displague left a comment

Choose a reason for hiding this comment

gianarb commented Sep 2, 2020

displague Sep 2, 2020 • edited Loading

Choose a reason for hiding this comment

gianarb Sep 4, 2020

Choose a reason for hiding this comment

displague Sep 2, 2020

Choose a reason for hiding this comment

displague Sep 2, 2020 • edited Loading

Choose a reason for hiding this comment

gianarb Sep 2, 2020

Choose a reason for hiding this comment

displague Sep 2, 2020

Choose a reason for hiding this comment

gianarb Sep 2, 2020

Choose a reason for hiding this comment

rugwirobaker commented Sep 2, 2020

rugwirobaker commented Sep 2, 2020

codecov bot commented Sep 2, 2020 •

edited

Loading

displague Sep 2, 2020 •

edited

Loading

displague Sep 2, 2020 •

edited

Loading