Simple refactors #283
Merged
Simple refactors #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
force-pushed
the
simple-refactors
branch
from
58514cd to
f5f8c2d
Compare
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 20.58% 20.78% +0.20%
==========================================
Files 15 15
Lines 1365 1342 -23
==========================================
- Hits 281 279 -2
+ Misses 1070 1049 -21
Partials 14 14
Continue to review full report at Codecov.
|
mmlb
requested review from
kqdeng,
parauliya and
gauravgahlot
and removed request for
kqdeng
gauravgahlot
previously approved these changes
Sep 9, 2020
gianarb
previously approved these changes
Sep 9, 2020
Signed-off-by: Manuel Mendez <[email protected]>
So the pb.go files are in line with our coding standards. Signed-off-by: Manuel Mendez <[email protected]>
These are never re-assigned to so there's no real reason to define as an empty string and later updated a couple lines below. After that clean up there's no reason not to make it a `const`. Having it `const` helps to convey that its never meant to be updated. Signed-off-by: Manuel Mendez <[email protected]>
`fn` is only ever assigned to once and then just called. This is no different than just calling the underlying functions, so lets do that. Signed-off-by: Manuel Mendez <[email protected]>
mmlb
force-pushed
the
simple-refactors
branch
from
f5f8c2d to
0b0de6b
Compare
mmlb
requested review from
gianarb and
gauravgahlot
and removed request for
kqdeng and
parauliya
gauravgahlot
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR cleans up some code that stood out as pretty weird when I was reading through it. Some simple function calls were being wrapped in a local var and then called via it. This is pretty odd since we can just as easily call the underlying function. Along the way I cleaned up the
msgvariable definitions from being done in multiple lines into just one as a const to better reflect how its actually used.How Has This Been Tested?
Still compiles, tests pass.