Tink CLI now flags an error if template ID does not exist, while creating a workflow #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauravgahlot
added
kind/bug
gauravgahlot
force-pushed
the
invalid-template
branch
from
95aae15 to
c11749a
Compare
Codecov Report
@@ Coverage Diff @@
## master #286 +/- ##
==========================================
+ Coverage 20.78% 24.01% +3.22%
==========================================
Files 15 15
Lines 1342 1345 +3
==========================================
+ Hits 279 323 +44
+ Misses 1049 1003 -46
- Partials 14 19 +5
Continue to review full report at Codecov.
|
gauravgahlot
added
needs-tests
Signed-off-by: Gaurav Gahlot <[email protected]>
gauravgahlot
force-pushed
the
invalid-template
branch
from
c11749a to
0eb9159
Compare
Signed-off-by: Gaurav Gahlot <[email protected]>
gauravgahlot
force-pushed
the
invalid-template
branch
from
0eb9159 to
a35bf29
Compare
gauravgahlot
added
added-tests
and removed
do-not-merge
gauravgahlot
added
the
priority/critical-urgent
gauravgahlot
added
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return error if no template is found for the provided template ID.
Why is this needed
Fixes: #282
How Has This Been Tested?
By attempting to create a workflow with non-existing and existing workflow ID.
How are existing users impacted? What migration steps/scripts do we need?
Fixes a bug.
Checklist:
I have: