Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move terraform to sandbox #289

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Move terraform to sandbox #289

merged 1 commit into from
Sep 10, 2020

Conversation

gianarb
Copy link
Contributor

@gianarb gianarb commented Sep 10, 2020

This is not needed here anymore. Developer can figure out their best
development environment. And this is used as a Setup guide for users. So
sandbox is a better place

#228

This is not needed here anymore. Developer can figure out their best
development environment. And this is used as Setup guide for users. So
`sandbox` is a better place

Signed-off-by: Gianluca Arbezzano <[email protected]>
@codecov
Copy link

codecov bot commented Sep 10, 2020

Codecov Report

Merging #289 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #289   +/-   ##
=======================================
  Coverage   24.01%   24.01%           
=======================================
  Files          15       15           
  Lines        1345     1345           
=======================================
  Hits          323      323           
  Misses       1003     1003           
  Partials       19       19           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1117a1b...d16e7b3. Read the comment docs.

Copy link
Contributor

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This finally removes all the installer work from the "code" repositories 🎉

@gianarb gianarb added the ready-to-merge Signal to Mergify to merge the PR. label Sep 10, 2020
@mergify mergify bot merged commit 84b3faf into tinkerbell:master Sep 10, 2020
@mmlb mmlb removed the ready-to-merge Signal to Mergify to merge the PR. label Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants