Fixed #291 : tink template commands exit in case of template file does not exist #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lure 1. tink template create command should fail in case of any failures 2. tink template update command should fail in case of any failures Signed-off-by: parauliya <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #293 +/- ##
=======================================
Coverage 24.01% 24.01%
=======================================
Files 15 15
Lines 1345 1345
=======================================
Hits 323 323
Misses 1003 1003
Partials 19 19 Continue to review full report at Codecov.
|
parauliya
changed the title
gauravgahlot
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: parauliya [email protected]
Description
Why is this needed
Fixes: #291
How Has This Been Tested?
Tested manually using vagrant
How are existing users impacted? What migration steps/scripts do we need?
No impact on existing users.
Checklist:
I have: